Fix to disable options that crash on AMD Navi 32 and Navi 48#1032
Merged
BenLubar merged 2 commits intoreactivedrop_betafrom Mar 28, 2026
Merged
Fix to disable options that crash on AMD Navi 32 and Navi 48#1032BenLubar merged 2 commits intoreactivedrop_betafrom
BenLubar merged 2 commits intoreactivedrop_betafrom
Conversation
Member
|
if someone has r_shadows 0 then having rd_flashlightshadows 1 and/or rd_env_projectedtexture_enabled 1 wont matter, game will act like those are on 0 |
BenLubar
reviewed
Mar 27, 2026
| // if AMD | ||
| if (info.m_VendorID == 0x1002) { | ||
| // navi 32 | ||
| if (strstr(driverName, "7700") != null) return true; |
Contributor
There was a problem hiding this comment.
should either be using nullptr or NULL; not sure what null is.
Contributor
Author
There was a problem hiding this comment.
Code worked, it was defined in vgui.h:
#define null 0L
But I removed the null's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick workaround, but in the meantime, this fixes #1001